Skip to content

Modify Tabs and create demo panel #129

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

Modify Tabs and create demo panel #129

wants to merge 7 commits into from
+109 −11

Conversation

@clarasb
Copy link
Collaborator

@clarasb clarasb commented Nov 14, 2025 •
edited
Loading

This PR:

  • made changes to the return value of the Tabs component.
  • adds a demo panel that showcases the Tabs component
grafik

@codecov
Copy link

codecov bot commented Nov 14, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.21%. Comparing base (3403cfd) to head (19ad7ec).

Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #129      +/-   ##
==========================================
+ Coverage   92.17%   92.21%   +0.03%     
==========================================
  Files          86       86              
  Lines        1496     1503       +7     
  Branches      225      231       +6     
==========================================
+ Hits         1379     1386       +7     
  Misses         98       98              
  Partials       19       19
Flag Coverage Δ
backend 100.00% <ø> (ø)
frontend 83.90% <100.00%> (+0.15%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@clarasb clarasb marked this pull request as ready for review November 14, 2025 17:26
@clarasb clarasb requested a review from forman November 14, 2025 17:26
@clarasb
Merge remote-tracking branch 'origin/main' into clarasb-xxx-add_demo_…
d6a515a 
…panel_8

# Conflicts:
#	chartlets.js/CHANGES.md
@clarasb clarasb requested a review from b-yogesh November 26, 2025 08:46
b-yogesh
b-yogesh reviewed Nov 28, 2025
View reviewed changes
Copy link
Collaborator

@b-yogesh b-yogesh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

The content inside the tabs dont show for me, am I missing something?

@clarasb
Copy link
Collaborator Author

clarasb commented Nov 28, 2025

@b-yogesh: Did you run npm run build before running the demo?

@clarasb clarasb requested a review from b-yogesh November 28, 2025 09:13
@b-yogesh
Copy link
Collaborator

b-yogesh commented Nov 28, 2025

@b-yogesh: Did you run npm run build before running the demo?

Yes, I forgot that, it works fine now.

b-yogesh
b-yogesh requested changes Nov 28, 2025
View reviewed changes
Copy link
Collaborator

@b-yogesh b-yogesh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works. I added a couple of Box components following the MUI examples shown here: https://mui.com/material-ui/react-tabs/#BasicTabs.tsx.

Although it looks like the suggested change is quite a lot, it is just a couple of lines. If you agree, please incorporate these changes.

@clarasb clarasb requested a review from b-yogesh November 28, 2025 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@b-yogesh b-yogesh b-yogesh approved these changes

@forman forman Awaiting requested review from forman

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@clarasb @b-yogesh